Do not always color skeletons table black #1952
Conversation
WalkthroughThe pull request removes the Changes
Possibly related PRs
Suggested labels
Poem
Tip New featuresWalkthrough comment now includes:
Notes:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1952 +/- ##
===========================================
+ Coverage 73.30% 75.36% +2.05%
===========================================
Files 134 133 -1
Lines 24087 24467 +380
===========================================
+ Hits 17658 18439 +781
+ Misses 6429 6028 -401 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- sleap/gui/dataviews.py (2 hunks)
Additional comments not posted (2)
sleap/gui/dataviews.py (2)
Line range hint
1-1: Verify the impact of removingget_item_colorfromSkeletonEdgesTableModel.The
get_item_colormethod has been completely removed from theSkeletonEdgesTableModelclass. This method was responsible for retrieving the color of an item based on itssourceanddestinationattributes using thecolor_manager.The removal of this method indicates a potential change in how item colors are managed or displayed within the application. It's crucial to verify that this removal does not lead to any unintended consequences or issues in the functionality related to item color retrieval.
To verify the impact of this change, please run the following script:
Please provide the output of running this script and confirm if there are any concerns regarding the removal of
get_item_colorfromSkeletonEdgesTableModel. If there are no issues found, please explicitly mention that in your response.
Line range hint
1-1: Verify the impact of removingget_item_colorfromSkeletonNodesTableModel.The
get_item_colormethod has been completely removed from theSkeletonNodesTableModelclass. This method was responsible for retrieving the color of an item based on itskeyattribute using thecolor_manager.The removal of this method indicates a potential change in how item colors are managed or displayed within the application. It's crucial to verify that this removal does not lead to any unintended consequences or issues in the functionality related to item color retrieval.
To verify the impact of this change, please run the following script:
Please provide the output of running this script and confirm if there are any concerns regarding the removal of
get_item_colorfromSkeletonNodesTableModel. If there are no issues found, please explicitly mention that in your response.
Description
Previously, our logic for coloring the items in the skeletons table had morphed unnoticed overtime from the initial feature (Apply node/edge color to skeleton tables.) and eventually resulted in it always being colored black.
In this PR, we simply remove the
SkeletonEdgesTableModel.get_item_colorandSkeletonNodesTableModel.get_item_colormethods which defaults to the Qt coloring (that is used for our other tables).Types of changes
Does this address any currently open issues?
Outside contributors checklist
Thank you for contributing to SLEAP!
❤️
Summary by CodeRabbit
Bug Fixes
Refactor